Merged
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…ction Signed-off-by: Andres Taylor <andres@planetscale.com>
…orrect tablet Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
… shards if a subset fails Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…nd works Signed-off-by: deepthi <deepthi@planetscale.com>
…st healthcheck Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…ction Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
…ction Signed-off-by: Andres Taylor <andres@planetscale.com>
sougou
reviewed
Jun 3, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Nice work. Got a few questions.
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
ds-replica-transaction
branch
from
2a7d8e4 to
e7887c4
Compare
…rpc client ignores the value of the alias in the response for backwards compatibility Signed-off-by: deepthi <deepthi@planetscale.com>
…mmit failed, this will be best effort and any errors are ignored. Signed-off-by: deepthi <deepthi@planetscale.com>
systay
approved these changes
Jun 4, 2020
Collaborator
|
The failing endtoend test is failing on master as well |
…ction Signed-off-by: Andres Taylor <andres@planetscale.com>
sougou
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6166